Add ignition API types #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-demicev
force-pushed
the
ignitionapi
branch
from
a091129
to
90b05a6
Compare
alexander-demicev
force-pushed
the
ignitionapi
branch
4 times, most recently
from
33014b1
to
6216565
Compare
belgaied2
reviewed
Mar 27, 2023
| return nil | ||
| } | ||
|
|
||
| return apierrors.NewInvalid(GroupVersion.WithKind("KubeadmConfig").GroupKind(), name, allErrs) |
alexander-demicev
force-pushed
the
ignitionapi
branch
from
6216565
to
bccdbd5
Compare
richardcase
previously approved these changes
Mar 27, 2023
| // generated cloud-init script. | ||
| // NOTE: All fields of the UserData that are managed by the RKE2Config controller will be ignored, this include "write_files", "runcmd", "ntp". | ||
| // Format specifies the output format of the bootstrap data. Defaults to cloud-config. | ||
| // +optional |
There was a problem hiding this comment.
As we are defaulting the value to cloud init should we also add the default here?
There was a problem hiding this comment.
I thought we agreed on defaulting values only in a webhook and not using open API schema for this, do I remember it wrong? I can add a default tag here if needed.
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
alexander-demicev
force-pushed
the
ignitionapi
branch
from
bccdbd5
to
67d46fe
Compare
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds an Ignition type to the bootstrap API and a validation/defaulting webhook.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: