Implement metadata propagation on the workload cluster nodes #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
force-pushed
the
propagate-annotations
branch
20 times, most recently
from
28f4a5c
to
4b2ca55
Compare
Danil-Grigorev
requested review from
belgaied2,
richardcase and
alexander-demicev
Danil-Grigorev
force-pushed
the
propagate-annotations
branch
from
4b2ca55
to
2388fb7
Compare
|
@Danil-Grigorev - i think that we should update the existing e2e to ensure that the labels and annotations do get propogated to the nodes. |
|
Also, the DCO check is failing. |
4 tasks
Danil-Grigorev
force-pushed
the
propagate-annotations
branch
from
2388fb7
to
66bca65
Compare
Danil-Grigorev
force-pushed
the
propagate-annotations
branch
4 times, most recently
from
8d6d489
to
352d08a
Compare
Danil-Grigorev
force-pushed
the
propagate-annotations
branch
2 times, most recently
from
d045cb1
to
92999f0
Compare
alexander-demicev
previously approved these changes
Oct 27, 2023
|
We can add e2e tests in a follow-up PR as discussed with @Danil-Grigorev |
richardcase
reviewed
Oct 27, 2023
Danil-Grigorev
force-pushed
the
propagate-annotations
branch
from
ab9efb9
to
56f4d82
Compare
Danil-Grigorev
force-pushed
the
propagate-annotations
branch
from
56f4d82
to
2ee1647
Compare
alexander-demicev
previously approved these changes
Oct 30, 2023
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
propagate-annotations
branch
from
2ee1647
to
021c148
Compare
alexander-demicev
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kind/feature
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #155
Special notes for your reviewer:
Checklist: