Fix issue with registries required fields #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-demicev
previously approved these changes
Jul 8, 2024
alknopfler
force-pushed
the
fix-issue-with-registry
branch
from
9889a88
to
7441557
Compare
alknopfler
force-pushed
the
fix-issue-with-registry
branch
2 times, most recently
from
28c2d56
to
83d3c09
Compare
alknopfler
force-pushed
the
fix-issue-with-registry
branch
3 times, most recently
from
db3cb31
to
40cf740
Compare
Signed-off-by: Alberto Morgante Medina <alberto.morgante@suse.com>
alknopfler
force-pushed
the
fix-issue-with-registry
branch
from
40cf740
to
c4ba227
Compare
alexander-demicev
approved these changes
Jul 10, 2024
Danil-Grigorev
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The registry TLS configuration requires the 3 values ca.crt, tls.crt, tls.key when only ca.crt is required (in case the registry does not need the client certs). With the current code, you're not able to include only the ca.crt. Also, there's no way to include the insecureSkipVerify flag to remove the rest of certs (we're skipping)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: