added kafka to rancher catalog #1
Conversation
| version: 0.8.2-rancher1 | ||
| category: clustering | ||
| release by: Raul Sanchez | ||
| requires: rancher-0.47.0 |
There was a problem hiding this comment.
this field should be minimum_rancher_version
There was a problem hiding this comment.
i saw this field in other packages in your offical repo. Do you have docs about the rules that you say??
|
Thanks for opening this PR! Couple comments in line. |
|
Could you rebase master, and squash? I messed up the CI configuration, and it should now be more correct. Thanks! |
|
Please squash. I ran the CI tests locally, and everything looked good there. |
|
squash done. |
|
Sorry, we typically squash all our commits into a single commit. I ran the CI scripts manually, and it all worked. It looks like the validation directory didn't get into that merge. I think if you roll back the last merge commit on your branch, and set this repo as a git remote, you should be able to: Of course I recommend saving a copy of your directory, just in case it goes completely awry :) while on your branch. The |
|
Aleluya!!!! :P |
| version: 0.8.2-rancher1 | ||
| category: clustering | ||
| maintainer: "Raul Sanchez <rawmind@gmail.com>" | ||
| minimum_rancher_version: rancher-0.56.0 |
There was a problem hiding this comment.
This needs to be v0.56.0 to work
There was a problem hiding this comment.
Done, parameter modified.
|
@rawmind0 , Why two versions of the Kafka template, 0 and 1? If a user were to deploy template 0 they would immediately be prompted to upgrade to version 1 of the template folders. Can we consolidate down to a single template as the initial pull? |
|
Done |
|
LGTM, @vincent99 ? |
|
Not sure why README.md changed and would prefer squashing, but LGTM |
|
@rawmind0, can you squash, and we will merge this in? |
Update config.yml Update config.yml Update config.yml Update config.yml Update config.yml Update fields as requested. updated kafka catalog service. Refactor confd to be compatible with rancher-metadata v2 updated kafka catalog service. Refactor confd to be compatible with rancher-metadata v2 fix config.yml minimum_rancher_version param Added zookeeper service and refactor kafka service upgrade kafka version 0.9.0 consolidate down to a single template
|
Done |
|
Awesome! Thank you. |
added kafka to rancher catalog
added kafka to rancher catalog
merge upstream
scaled number as question; added health check; set a concrete image v…
Pull request from rancher/community-catalog:master
…hcheck-fix-1 add interval to load balancer health check
Resubmiting pull request as you request me.
Added kafka + zk cluster to catalog. The clusters (zk and kafka) can scale and reconfigures itselfs based in rancher-metadata.