address pr comments

rancher · May 6, 2024 · 7c62f73 · 7c62f73
1 parent 3b7d486
commit 7c62f73
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/cypress/e2e/po/pages/users-and-auth/roles.po.ts b/cypress/e2e/po/pages/users-and-auth/roles.po.ts
@@ -32,6 +32,10 @@ export default class RolesPo extends PagePo {
     return new GlobalRoleDetailPo(this.clusterId, roleId);
   }
 
+  goToEditYamlPage(elemName: string) {
+    return this.list().actionMenu(elemName).getMenuItem('Edit YAML').click();
+  }
+
   createRole(userId?: string) {
     return new RoleTemplateEditPo(this.clusterId, userId);
   }

diff --git a/cypress/e2e/tests/pages/users-and-auth/roles.spec.ts b/cypress/e2e/tests/pages/users-and-auth/roles.spec.ts
@@ -68,7 +68,7 @@ describe('Roles', { tags: ['@usersAndAuths', '@adminUser'] }, () => {
       roles.waitForPage(undefined, fragment);
 
       // testing https://github.com/rancher/dashboard/issues/9800
-      roles.list().actionMenu(globalRoleName).getMenuItem('Edit YAML').click();
+      roles.goToEditYamlPage(globalRoleName);
 
       createGlobalRole.yamlEditor().value().then((val) => {
         // convert yaml into json to update values