Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This refactors the
nuxtClientInit
action so that mutations are explicitly invoked in the store instead of utilizingObject.defineProperty()
to modify the root state.Fixes #11081
Technical notes summary
Vue 3 wraps the store's state object with a proxy to make it reactive, and the proxy's target object has its properties marked as non-writable and non-configurable. In order to resolve this issue, we make use of accepted Vuex patterns for modifying state.
Areas or cases that should be tested
This is the core store module, so we will need to test anything that utilizes the
$router
,$route
, and$plugin
state that's defined within the store.Areas which could experience regressions
Anything that accesses the
$router
,$route
, or$plugin
states stored in the store.Checklist