Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Vuex implementation to be compatible with Vue 3's reactivity system #11081

Closed
1 task done
rak-phillip opened this issue May 21, 2024 · 3 comments · Fixed by #11062
Closed
1 task done

Upgrade Vuex implementation to be compatible with Vue 3's reactivity system #11081

rak-phillip opened this issue May 21, 2024 · 3 comments · Fixed by #11062
Assignees
Labels
QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone

Comments

@rak-phillip
Copy link
Member

rak-phillip commented May 21, 2024

The current Vuex implementation for Dashboard is not fully compatible with Vue 3's reactivity system. Using Object.defineProperty() on the root state will generate the following error

Uncaught (in promise) TypeError: proxy must report the same value for the non-writable, non-configurable property '"$plugin"'

This error occurs because Vue 3 wraps the store's state object with a proxy to make it reactive, and the proxy's target object has its properties marked as non-writable and non-configurable.

@rak-phillip rak-phillip added this to the v2.9.0 milestone May 21, 2024
@rak-phillip rak-phillip self-assigned this May 21, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label May 21, 2024
@yonasberhe23
Copy link
Contributor

I don't see automated tests written for this change. is it possible to write tests for this or should this be tested manually? @rak-phillip

@rak-phillip
Copy link
Member Author

@yonasberhe23 this is a refactor that should be covered by existing e2e tests.

@yonasberhe23
Copy link
Contributor

@rak-phillip thanks! moving this to done. cc: @izaac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants