Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: Server-side pagination setting is enabled when user hits cancel option #11497

Closed
Tracked by #8527
yonasberhe23 opened this issue Jul 19, 2024 · 2 comments · Fixed by #11505
Closed
Tracked by #8527
Assignees
Labels
area/performance area/server-side-pagination candidate-automation Candidate for being covered by automated tests kind/bug QA/manual-test Indicates issue requires manually testing status/backport-candidate
Milestone

Comments

@yonasberhe23
Copy link
Contributor

yonasberhe23 commented Jul 19, 2024

Setup

  • Rancher version: v2.9-head
  • Rancher UI Extensions:
  • Browser type & version:

Describe the bug
Although the user clicks cancel, the server-side pagination setting is enabled/checked.

To Reproduce

  1. go to Global settings > feature flags > enable ui-sql-cache
  2. go to Global settings > feature flags > enable `Server-sdie Pagination'
  3. hit cancel on the Are you sure? modal
  4. notice setting is checked

Result
setting is checked before the user hits 'Enable'.

Expected Result
setting is unchecked until the user clicks 'Enable'.

Screenshots

Screen.Recording.2024-07-19.at.1.29.02.PM.mov

Additional context

@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Jul 19, 2024
@yonasberhe23 yonasberhe23 added this to the v2.9.0 milestone Jul 19, 2024
@yonasberhe23 yonasberhe23 changed the title Performance: Server-side pagination setting remains enabled when user hits cancel option Performance: Server-side pagination setting is enabled when user hits cancel option Jul 19, 2024
@richard-cox
Copy link
Member

Gonna bump this to 2.10.0 as i don't think it's a release blocker.

  • Perf pagination checkbox is only enabled once the ui-cache FF is enabled. This is an experimental feature not designed for production. So to get there the user is already in non-prod.
  • Perf setting although enabled (and visually so) is not applied until user clicks save

@richard-cox richard-cox modified the milestones: v2.9.0, v2.10.0 Jul 22, 2024
@richard-cox richard-cox added QA/manual-test Indicates issue requires manually testing candidate-automation Candidate for being covered by automated tests and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Aug 19, 2024
@yonasberhe23 yonasberhe23 self-assigned this Aug 22, 2024
@yonasberhe23
Copy link
Contributor Author

The setting remains unchecked until the user clicks 'Enable' on the incompatible modal. + Regression tests passed.

Tested in:

  • Rancher v2.10-3ed01c34581afc6bcc4da77c78127d982e13a405-head
  • Dashboard master 340d410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance area/server-side-pagination candidate-automation Candidate for being covered by automated tests kind/bug QA/manual-test Indicates issue requires manually testing status/backport-candidate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants