Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for options when restoring RKE2 cluster etcd snapshots #4539

Closed
Tracked by #3346
snasovich opened this issue Nov 10, 2021 · 6 comments
Closed
Tracked by #3346

Support for options when restoring RKE2 cluster etcd snapshots #4539

snasovich opened this issue Nov 10, 2021 · 6 comments

Comments

@snasovich
Copy link
Contributor

snasovich commented Nov 10, 2021

Detailed Description

Following the implementation of rancher/rancher#35468, the UI should support options to restore either "Kubernetes version and etcd" or "Cluster config, Kubernetes version and etcd" similar to how RKE1 supports on the following dialog (note "etcd only" option is not needed).
image

Note: This issue should be updated once more details are known on how the updated etcd snapshot is going to work in RKE2.

Context
This is needed for RKE2 provisioning parity with RKE1 provisioning.

@codyrancher
Copy link
Contributor

@snasovich is the ask here to just remove the 'Only etcd' option? From reading the dependent ticket it sounds like we might want more than that.

@snasovich
Copy link
Contributor Author

@codyrancher , the ask here is to support restoring RKE2/k3s downstream clusters' etcd backups on the Dashboard UI. (So, not modifying the existing form to remove additional option.)
How to actually kick off restore depends on backend implementation that @Oats87 is working on.
@Oats87 will be providing the information on how to kick off restore and pass options.

@gaktive
Copy link
Member

gaktive commented Feb 16, 2022

Work moved to rancher/rancher#34417 which is in QA to test, so this looks ready for UI.

@snasovich
Copy link
Contributor Author

@gaktive @codyrancher , Chris provided a summary of backend changes: rancher/rancher#34417 (comment)

Please us know if more clarifications are needed or you run into issues.
Also, there is a change in where snapshot data is stored (moved from cluster object to their own CRs). Do we need a separate UI issue on this or it can be included in this one?

@timhaneunsoo
Copy link

Test Environment:

Rancher version: v2.6-head
Rancher cluster type: HA
Docker version: 20.10

Downstream cluster type: RKE2 node driver


Testing:

Tested this issue with the following steps:

  1. Create RKE2 node driver cluster
  2. Create couple manual snapshots
  3. Click on restore snapshot and confirm the options given to user

Result - Pass

etcd snapshot is showing the proper options and is in parity with RKE1 provisioning
Screen Shot 2022-03-03 at 10.04.03 AM.png

@jtravee
Copy link

jtravee commented Mar 16, 2022

Confirmed with @catherineluse and @gaktive to add release note label.

@zube zube bot removed the [zube]: Done label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment