Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a detail view for Fleet Bundle Resource #4793

Closed
nwmac opened this issue Dec 17, 2021 · 4 comments
Closed

Create a detail view for Fleet Bundle Resource #4793

nwmac opened this issue Dec 17, 2021 · 4 comments
Assignees
Milestone

Comments

@nwmac
Copy link
Member

nwmac commented Dec 17, 2021

The Fleet resource fleet.cattle.io.bundle does not have a detail view - we should add one.

Currently we show the YAML for the bundle as there is no detail view - for large bundles, this is slow to load - hopefully adding a detail view will avoid this - the user would still then be able to switch to the YAML view.

You should look in the detail folder for examples - but as long as the vue file in that folder is named with the resource name, it will be shown as the default view instead of the YAML.

Take a look at the details of the bundle resource and choose appropriate data to show on the detail view, e.g.

  • The type of the bundle (kustomize, helm etc) - I think we can get this from the values under the spec
  • The number of resources in the bundle (could show the list of resources too)
  • The ready cluster information
  • Status information for the bundle
  • The clusters that the bundle it deployed to

You should manually create a large bundle (the max resource size is 1MB) and check that currently when you view the bundle it is slow to load and then check that with the detail view, this is no longer the case - we need to check if the slowness is dues ot the YAML rendering or the data fetch.

@nwmac nwmac added this to the v2.6.4 milestone Dec 17, 2021
@MKlimuszka MKlimuszka added the team/area3 Helm Yes! label Jan 28, 2022
Shavindra added a commit that referenced this issue Mar 9, 2022
* Add Git Repo intro page.

* Flett bundle status updates.

* Fleet GitRepo page updates.

* Add fleet status dropdown.

* Update Fleet states.

* Display bundle resources.

Co-authored-by: Alexandre Alves <aalves@AlexandresMBP2.lan>
@zube zube bot assigned izaac and unassigned davidnuzik Mar 16, 2022
@jtravee
Copy link

jtravee commented Mar 16, 2022

Confirmed with @catherineluse and @gaktive to add release note label.

@izaac
Copy link
Contributor

izaac commented Mar 17, 2022

Is this just click on a bundle to check its details ? Is that the view?

@Shavindra
Copy link
Contributor

@izaac Please refer to #5068 I've updated steps to test. It encompass multiple changes. Hope this is clear.

@bmdepesa
Copy link
Member

rancher/rancher:v2.6.4-rc10

Followed test instructions from: #5068

  • Deployed several clusters
  • Added example gitrepo
  • Clicking on the git repo shows the bundles included
  • With a bundle in an error state, the error is shown
  • Statuses are displayed in different colors on the distrobution graph
  • Counts of ready bundles/resources are shown
  • Dropdowns for Bundles and Resources show the detailed view of counts of the possible states
  • Pending statuses are shown correctly
  • The Bundles details page is accessible from the left nav-menu
  • All bundles are shown, and clicking on one shows the resources available

@zube zube bot closed this as completed Mar 22, 2022
@zube zube bot removed the [zube]: Done label Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants