Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form elements incorrectly hidden in Continuous Delivery Git Repo create/edit form for http:// repository URL #4830

Closed
gaktive opened this issue Dec 30, 2021 · 1 comment

Comments

@gaktive
Copy link
Member

gaktive commented Dec 30, 2021

Internal reference: SURE-3564
Reported in 2.6.2

Issue description:
When a non-TLS Git Repository URL is entered into the Git Repo create/edit form of the Continuous Delivery UI, not only is the TLS Certificate Verification section hidden (as expected) but the Paths, Deploy To Labels and Annotations are also hidden incorrectly. The conditional display logic incorrectly wraps these sections as well as the TLS Certificate Verification section (https://github.com/rancher/dashboard/blob/v2.6.2/edit/fleet.cattle.io.gitrepo.vue#L394)

Business impact:
Cannot use GitRepo form in Continuous Delivery UI to add a http: git repository

Troubleshooting steps:
N/A

Repro steps:

  • Provision a Rancher v2.6.2 instance
  • Navigate to the Continous Delivery UI, Git Repos view and click Create
  • Enter http:// in the Repository URL field

Workaround:
Is workaround available and implemented? Yes
What is the workaround: Create gitrepo resource from manifest versus UI form

Actual behavior:
All form sections below and including TLS Certificate Verification are hidden when entered Repository URL starts http:// i.e. Paths, Deploy To Labels and Annotations

Expected behavior:
Only TLS Certificate Verification are hidden when entered Repository URL starts http://

@izaac
Copy link
Contributor

izaac commented Mar 17, 2022

This is no longer reproducible on Rancher 2.6.4-rc8 and 2.4.6-rc9

@izaac izaac closed this as completed Mar 17, 2022
@zube zube bot removed the [zube]: Done label Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants