4830 - Fix show / Hide gitrepo create fields based on isTLS. #4893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-cox
requested changes
Jan 26, 2022
There was a problem hiding this comment.
The core change looks good and resolves the issue as stated, however it exposes another issue that will probably cause #4830 to fail QA so should be resolved at the same time.
When a non-tls url is supplied the two settings associated with tls aren't changed. Think this is fine for insecureSkipTLSVerify (guess this is ignored in the non-tls case) but it looks like we do custom stuff with caBundle on reload. To be safe it's probably best to clear both before the git repo is saved. This can be done in the same component using a registerBeforeHook.
richard-cox
approved these changes
Feb 28, 2022
|
@Shavindra You can go ahead and merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue #4830 - Form elements incorrectly hidden in Continuous Delivery Git Repo create/edit form for http:// repository URL.
Steps to test
https://github URL e.g.https://github.com/rancher/fleet-examples.gitsfromhttpse.g.http://github.com/rancher/fleet-examples.gitTLS Certificate Verificationfield when itshttp. Other fields should remain.Screen.Recording.2022-01-20.at.14.24.19.mov