Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix err when save deployment and service annotations is null #10110

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

hhstu
Copy link
Contributor

@hhstu hhstu commented Dec 4, 2023

Summary

Fixes #9978 fix err when save deployment and service annotations is null

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

@hhstu hhstu changed the title Fix service annotations null Fix err when save deployment and service annotations is null Dec 4, 2023
@richard-cox richard-cox added this to the v2.8.next1 milestone Dec 5, 2023
Copy link
Contributor

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac
Copy link
Member

nwmac commented Dec 5, 2023

@torchiaf You can go ahead and merge as the author doesn't have permission to do so.

@torchiaf torchiaf merged commit b0880fe into rancher:master Dec 5, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot read properties of undefined (reading 'cloudprovider.harvesterhci.io/ipam')
4 participants