remove v1 monitoring code #10539
Merged
remove v1 monitoring code #10539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nwmac @richard-cox added you both as reviewers since this need a keen eye. I went to each of those views and all looked good. |
richard-cox
requested changes
Mar 1, 2024
There was a problem hiding this comment.
There's a couple of items in the checklist that still need doing
The PR template has been filled out
The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
Automated test side, we probably need some to cover below. Hopefully all have existing tests though
- Node list --> click on one --> confirm something trivial on page
- Workload list --> click on one --> confirm something trivial on page
- Cluster Dashboard --> confirm something trivial on page
Monitoring is a bit more of a pain, would need some manual tests for that (it's a honker to install on the small image used by gh ci)
|
@richard-cox the issue has |
richard-cox
requested changes
Mar 20, 2024
added 3 commits
March 22, 2024 10:18
… strings + simple checks for detail pages in e2e tests to verify integrition of work done
aalves08
force-pushed
the
10490-remove-v1-monitoring-embedded-pages
branch
from
2d92165
to
5882ab0
Compare
richard-cox
approved these changes
Mar 22, 2024
codyrancher
pushed a commit
to codyrancher/dashboard
that referenced
this pull request
Apr 20, 2024
* remove v1 monitoring code * fix lint issue * remove monitoring v1 uninstall code + remove v1 uninstall translation strings + simple checks for detail pages in e2e tests to verify integrition of work done * address pr comments * fix unit tests --------- Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
codyrancher
pushed a commit
to codyrancher/dashboard
that referenced
this pull request
Apr 24, 2024
* remove v1 monitoring code * fix lint issue * remove monitoring v1 uninstall code + remove v1 uninstall translation strings + simple checks for detail pages in e2e tests to verify integrition of work done * address pr comments * fix unit tests --------- Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
codyrancher
added a commit
that referenced
this pull request
Apr 29, 2024
[backport v2.8.x] remove v1 monitoring code (#10539)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10490
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
nodedetail page works - Added simple assertion to https://github.com/rancher/dashboard/blob/master/cypress/e2e/tests/pages/explorer/node-list.spec.ts ✅poddetail page works - already covered in https://github.com/rancher/dashboard/blob/master/cypress/e2e/tests/pages/explorer/workloads/pods.spec.ts ✅workloaddetail page works - already covered in https://github.com/rancher/dashboard/blob/master/cypress/e2e/tests/pages/explorer/workloads/workloads.spec.ts ✅cluster explorerpage works - already covered by https://github.com/rancher/dashboard/blob/master/cypress/e2e/tests/pages/explorer/cluster-dashboard.spec.ts ✅c/cluster/monitoringpage worksv2 monitoringworksAreas which could experience regressions
Make sure we cover the areas mentioned in the previous points to avoid regressions. Manual testing might be needed to ensure V2 monitoring is working fine
Screenshot/Video
Screen.Recording.2024-03-11.at.11.17.17.mov
Checklist