Ensure too old messages for watches in individual resources are handled correctly
#10541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dled correctly - also fix issue where `find` on `resyncWatch` didn't work with namespaced resources
…ts still happened
- caused because
- resource.stop is sent alongside resource.error
- on resource.error we set the state of the watch to errored
- this was just using the root type as key and nothing else
- on resource.stop we call resource.start
- on resource.start we check for inError and bail if so
- this didn't happen, as we checked the inError using more than just root type
- fix is to make sure setInError useds same key process as inError getter
- this follows other places it's used
richard-cox
force-pushed
the
detail-socket-spam
branch
from
fe58d57
to
e6f10b9
Compare
- better comments - improved tests - handle trailing url `/`
nwmac
reviewed
Mar 8, 2024
| const urlObj = new URL(url); | ||
| const path = urlObj.pathname; | ||
|
|
||
| if (!!path?.length && path[path.length - 1] === '/') { |
nwmac
approved these changes
Mar 8, 2024
|
/backport v2.8.next1 release-2.8 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10540
Occurred changes and/or fixed issues
too oldfetch the latest version of the resource and re-watch without a revisiontoo oldrevision from the resource, resulting in thetoo oldmessage again ad nauseamTechnical notes summary
TODO: the fix for the second bug involves NOT sending a revision. this currently mean all changes are replayed over socket instead of just changes occurring after the watchNot sending a revision means we get the latest version of the resource in a resource.create event (it's not the original resource.create followed by everything else)Areas or cases that should be tested
As per repo steps
Areas which could experience regressions
Checklist