Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cluster's badge position #10710

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

momesgin
Copy link
Member

@momesgin momesgin commented Mar 27, 2024

Summary

Fixes #10667

A 4-pixel transparent border was affecting the positioning of the colored border. I could not figure out why this transparent border was added in the first place, but tried to test this change manually as much as I could in order to prevent any visual regression.

Areas or cases that should be tested

The cluster badge should be displayed properly in different states(e.g. active, disabled) and for different cluster types(e.g. local, custom)

Areas which could experience regressions

Same as above.

Screenshot/Video

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@momesgin momesgin added this to the v2.9.0 milestone Mar 27, 2024
@momesgin momesgin requested a review from scures March 27, 2024 15:00
@momesgin momesgin self-assigned this Mar 27, 2024
@momesgin momesgin marked this pull request as ready for review April 16, 2024 22:32
@momesgin
Copy link
Member Author

momesgin commented Apr 16, 2024

@scures I was wondering if you would know what that transparent border is used for?

Copy link
Contributor

@scures scures left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before it was an actual border (border-bottom) and I had to add a transparent one so the elements were of the same height (font+4px border)
But later, I changed that; there's now an element instead of a border

It's safe to remove it. Thanks for spotting it =)

@momesgin momesgin merged commit d5cc807 into rancher:master Apr 17, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Side Nav: Cluster Badge colour fails to reach bottom of cluster badge
2 participants