Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show state column on import yaml dialog #10730

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

aalves08
Copy link
Contributor

@aalves08 aalves08 commented Apr 1, 2024

Summary

Fixes #10656

Occurred changes and/or fixed issues

  • remove state col and subrows from import YAML action success screen
  • prevent sub-row form showing state description
  • add tests

Technical notes summary

Areas or cases that should be tested

  • got header -> Import a YAML -> fill out the YAML editor and hit save (should not show state col)

Areas which could experience regressions

Screenshot/Video

Screen.Recording.2024-03-28.at.12.35.03.mov

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 added this to the v2.9.0 milestone Apr 1, 2024
@aalves08 aalves08 requested a review from momesgin April 1, 2024 15:15
@aalves08 aalves08 self-assigned this Apr 1, 2024
shell/components/Import.vue Outdated Show resolved Hide resolved
cypress/e2e/po/components/header.po.ts Outdated Show resolved Hide resolved
cypress/e2e/po/components/sortable-table.po.ts Outdated Show resolved Hide resolved
@aalves08 aalves08 merged commit e6c4d01 into rancher:master Apr 9, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't show state column on import yaml dialog
2 participants