Fix AddProjectMemberDialog, remove scroll artifacts #10785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rak-phillip
reviewed
Apr 11, 2024
There was a problem hiding this comment.
Would it make sense to change pkg/rancher-components/src/components/Card/Card.vue instead of AddProjectMemberDialog?
There was a problem hiding this comment.
Right, but I was wondering if it can introduce side effects in other components where we are using Card.vue; however, I went through the UI and couldn't find any regressions.
| @@ -177,4 +177,7 @@ export default { | |||
| border: 1px solid var(--border); | |||
| box-shadow: none; | |||
| } | |||
| .card-container.card-sticky .card-wrap .card-body { | |||
| overflow: hidden | |||
There was a problem hiding this comment.
Would auto be more appropriate than hidden? I don't want to end up with a scenario where we would require scrolling, but are unable to do so.
torchiaf
force-pushed
the
10784-modal-add-member-css
branch
from
b8a0592
to
048b3ef
Compare
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
torchiaf
force-pushed
the
10784-modal-add-member-css
branch
from
048b3ef
to
ded51ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10784
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist