Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automation: part 2 of fixing flaky tests #10792

Merged
merged 6 commits into from
Apr 16, 2024

Conversation

yonasberhe23
Copy link
Contributor

Summary

Fixes #
Add intercept/waits to address

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

izaac
izaac previously approved these changes Apr 12, 2024
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

izaac
izaac previously approved these changes Apr 12, 2024
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yonasberhe23
Copy link
Contributor Author

The flakiness of the namespace-picker test was due to the Fleet check being in progress in a fresh Rancher install so the associated filters, such as cattle-fleet-local-system, aren't applied until after the Fleet check is complete. To fix this I updated the test to select ‘cattle-fleet-system’ instead because it exists upon user login which is more reliable.
cc: @izaac

Screenshot 2024-04-16 at 3 03 15 PM Screenshot 2024-04-16 at 3 05 31 PM

@yonasberhe23 yonasberhe23 merged commit da4a311 into rancher:master Apr 16, 2024
25 checks passed
@yonasberhe23 yonasberhe23 deleted the fix_tests branch April 16, 2024 22:11
@izaac
Copy link
Contributor

izaac commented Apr 16, 2024

Awesome, nice find

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants