Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rancher UI branding customisation is not persistent on the login screen #10796

Merged

Conversation

aalves08
Copy link
Contributor

@aalves08 aalves08 commented Apr 12, 2024

Summary

Fixes #10788

  • update brand mixin to handle login scenario for branding application of primary color and link color
  • add e2e tests to cover possible regression scenario

Occurred changes and/or fixed issues

Technical notes summary

Needed to convert the globalSettings variable in a getter-based in order to get the settings information from the network request done last to settings, which is done from the login view. Had to convert all the watchers to immediate: true in order to pick up changes

Areas or cases that should be tested

  • This needs a backend version 2.9-head with date 12th of April 2024 or later, due to changes done in rancher/rancher add missing settings for branding customisation of login/logout page rancher#45108
  • Go to Global Settings -> branding and change primary color and link color to custom ones
  • Log out of Rancher and check that the branding changes are applied
  • Do a refresh on the login page to check that changes persist
  • Log back into Rancher and check that general branding changes are applied

Areas which could experience regressions

Screenshot/Video

Screenshot 2024-04-12 at 16 10 03
Screenshot 2024-04-12 at 16 10 09
Screenshot 2024-04-12 at 16 10 17

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

…on of primary color and link color + add e2e tests
@aalves08 aalves08 self-assigned this Apr 12, 2024
@github-actions github-actions bot added this to the v2.9.0 milestone Apr 12, 2024
@aalves08 aalves08 requested a review from momesgin April 12, 2024 15:14
Copy link
Member

@eva-vashkevich eva-vashkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a refresh of login page to make sure it stays consistent on refresh, but overall looks good

Copy link
Member

@eva-vashkevich eva-vashkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aalves08 aalves08 merged commit f676ef3 into rancher:master Apr 15, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rancher UI branding customisation is not persistent on the login screen
2 participants