Rancher UI branding customisation is not persistent on the login screen #10796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10788
brand
mixin to handle login scenario for branding application ofprimary
color andlink
colorOccurred changes and/or fixed issues
Technical notes summary
Needed to convert the
globalSettings
variable in a getter-based in order to get the settings information from the network request done last to settings, which is done from thelogin
view. Had to convert all the watchers toimmediate: true
in order to pick up changesAreas or cases that should be tested
2.9-head
with date 12th of April 2024 or later, due to changes done inrancher/rancher
add missing settings for branding customisation of login/logout page rancher#45108Global Settings
->branding
and changeprimary
color andlink
color to custom onesAreas which could experience regressions
Screenshot/Video
Checklist