Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cluster dashboard certificates list ns filter agnostic #10828

Merged

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Apr 17, 2024

Summary

Related to #10025 / #10024

Occurred changes and/or fixed issues

  • The cluster dashboard page contains tabs
  • Tabs contain lists
  • One tab shows lists of events (non-namespaced resource), the other certificates (namespaced resource)
  • By default lists will filter rows of namespaced resources by the namespaces selected in the header filter
  • This works fine for root lists, and is ignored for lists with in the detail page of resources (as they're showing resources associated with the primary resource)
  • For lists that are in overview pages though we don't have a pattern
  • For this context and use case it feels discombobulating to filter by namespace
    • navigating to the local cluster and viewing cert list will by default not show any due to the user only namespaces filter

Areas or cases that should be tested

  • cluster dashboard --> certificates tab
  • entries do not change given the value of the ns filter

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

- We don't really have a pattern for filtering lists within overview pages (outside of detail pages)
- For this one, it felt weird going to the local cluster and seeing no certificates (as we default to only show resources in user namespaces)
@richard-cox richard-cox added this to the v2.9.0 milestone Apr 17, 2024
@richard-cox richard-cox self-assigned this Apr 17, 2024
@richard-cox richard-cox marked this pull request as ready for review April 17, 2024 13:45
Copy link
Contributor

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-cox richard-cox merged commit 2fe2c6b into rancher:master Apr 19, 2024
29 checks passed
@richard-cox richard-cox deleted the certificates-list-ns-agnostic branch April 19, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants