Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Performance of many helm chart based pages #10853

Merged
merged 6 commits into from
May 8, 2024

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Apr 22, 2024

Summary

Fixes #10448

Occurred changes and/or fixed issues

Technical notes summary

  • setting reset when calling catalog/load cleared the existing chart cache. This is called in four places
    • repo model's refresh action - force + reset
    • cluster tools visit - force + reset (not sure why we need to do this)
    • plugins page visit - reset
    • plugins page refresh button - reset + force
  • now reset also clears the chart version cache

Areas or cases that should be tested

  • Refreshing helm repos
  • Cluster tools page
  • Extensions page

Areas which could experience regressions

Areas as above

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

- setting `reset` when calling catalog/load cleared the existing chart cache. This is called in four places
  - repo model's `refresh` action - force + reset
  - cluster tools visit - force + reset (not sure why we need to do this)
  - plugins page visit - reset
  - plugins page refresh button - reset + force
- now `reset` also clears the chart version cache
@richard-cox richard-cox marked this pull request as ready for review May 7, 2024 14:40
@richard-cox richard-cox merged commit f136df3 into rancher:master May 8, 2024
28 checks passed
@richard-cox richard-cox deleted the fix-chart-performance branch May 8, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce the times we go out and fetch all charts
2 participants