-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E Tests: Reduce default timeout #10863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment, otherwise looks good
018f175
to
9f3762a
Compare
@richard-cox @aalves08 This one finally passed the gates - would be good to get this in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments only worth changing if there's further updates
@@ -9,6 +9,9 @@ import { ChartsPage } from '@/cypress/e2e/po/pages/explorer/charts/charts.po'; | |||
import { InstallChartPage } from '@/cypress/e2e/po/pages/explorer/charts/install-charts.po'; | |||
import { PrometheusTab } from '@/cypress/e2e/po/pages/explorer/charts/tabs/prometheus-tab.po'; | |||
import { GrafanaTab } from '@/cypress/e2e/po/pages/explorer/charts/tabs/grafana-tab.po'; | |||
import { AlertingTab } from '@/cypress/e2e/po/pages/explorer/charts/tabs/alerting-tab.po'; | |||
import { IstioTab } from '@/cypress/e2e/po/pages/explorer/charts/tabs/istio-tab.po'; | |||
import { LONG_TIMEOUT_OPT } from '~/cypress/support/utils/timeouts'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if there's another pr change, this could be updated to @/
@@ -44,11 +44,20 @@ describe('Charts', { tags: ['@charts', '@adminUser'] }, () => { | |||
|
|||
installPage.waitForPage('repo-type=cluster&repo=rancher-charts&chart=rancher-backup'); | |||
|
|||
// Scroll into view - scroll to bottom of view | |||
cy.get('.main-layout > .outlet > .outer-container').scrollTo('bottom'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional, should this go on the PagePo
as a helper?
Fixes #8956
This PR reduces the default cypress timeout used in e2e tests from 60s to 10s.
There are a few tests that need updating to specifically used a longer timeout - a set of timeouts has been created in a utility file and used in the appropriate places.
When a test fails, the test is retried 3 times - so before this PR, a test failure would add 3 minutes to the test run - with this PR it adds 30 seconds.
We can look to reduce the timeout further, but more tests will need to be checked and updated.
This PR also updates a couple of tests to make them more resilient:
Also added tag for
ember
and applied to relevant tests.