Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Automation] - Cluster Details - Conditions and Related #10867

Merged
merged 1 commit into from
May 2, 2024
Merged

[Automation] - Cluster Details - Conditions and Related #10867

merged 1 commit into from
May 2, 2024

Conversation

izaac
Copy link
Contributor

@izaac izaac commented Apr 23, 2024

Summary

Related task rancher/qa-tasks#758

Occurred changes and/or fixed issues

Adding navigation to the Conditions and Related Resources tabs on Cluster Details.

Technical notes summary

Navigation and basic assertion of tables and rows content.

Areas or cases that should be tested

N/A

Areas which could experience regressions

Automation

Screenshot/Video

Screenshot from 2024-04-23 11-29-32
Screenshot from 2024-04-23 11-29-50

Checklist

  • [ x ] The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • [ x ] The PR has a Milestone
  • [ x ] The PR template has been filled out
  • [ x ] The PR has been self reviewed
  • [ x ] The PR has a reviewer assigned
  • [ x ] The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@izaac izaac added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Apr 23, 2024
@izaac izaac added this to the v2.9.0 milestone Apr 23, 2024
@izaac izaac requested a review from yonasberhe23 April 23, 2024 18:33
@izaac izaac force-pushed the cluster_details_tabs branch 3 times, most recently from e61a27b to f14452a Compare May 1, 2024 14:36
@izaac
Copy link
Contributor Author

izaac commented May 1, 2024

I think it's ready for review. Covers:

rancher/qa-tasks#755
rancher/qa-tasks#756
rancher/qa-tasks#758

yonasberhe23
yonasberhe23 requested changes May 1, 2024
View reviewed changes
Copy link
Contributor

@yonasberhe23 yonasberhe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments with proposed changes. lmk if you have questions

@izaac izaac force-pushed the cluster_details_tabs branch 7 times, most recently from 3fa72ef to 44c7676 Compare May 1, 2024 19:53
@izaac izaac force-pushed the cluster_details_tabs branch 2 times, most recently from 2d2b45b to fd134a5 Compare May 1, 2024 23:05
@izaac izaac merged commit ee4ad73 into rancher:master May 2, 2024
25 checks passed
@izaac izaac deleted the cluster_details_tabs branch May 2, 2024 20:03
@izaac izaac mentioned this pull request May 6, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonasberhe23 yonasberhe23 yonasberhe23 approved these changes

Assignees

@izaac izaac

Labels
QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@izaac @yonasberhe23