Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add e2e test for issue 10412 #10898

Merged
merged 4 commits into from
May 8, 2024
Merged

Conversation

aalves08
Copy link
Contributor

@aalves08 aalves08 commented Apr 29, 2024

Summary

Fixes #10412 (e2e testing)

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08
Copy link
Contributor Author

aalves08 commented May 7, 2024

@torchiaf @momesgin I've rebased #10872 so this should be ready for a review 🙏

Copy link
Member

@momesgin momesgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalves08 aalves08 merged commit ab79990 into rancher:master May 8, 2024
27 checks passed
@izaac izaac self-requested a review May 8, 2024 17:52
@izaac
Copy link
Contributor

izaac commented May 8, 2024

Is this something that can be accomplished provisioning real Clusters? There are provisioning capabilities to provision AWS and Azure RKE2 clusters in the framework now. @aalves08 @momesgin

@izaac
Copy link
Contributor

izaac commented May 8, 2024

I'll keep the referred issue opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants