Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign vGpu id when assigning vGpus to Harvester Cluster #10913

Merged
merged 3 commits into from
May 2, 2024

Conversation

torchiaf
Copy link
Contributor

@torchiaf torchiaf commented Apr 30, 2024

Summary

Fixes #10905

Occurred changes and/or fixed issues

Technical notes summary

The vGpu name should be same of vGpu id from Harvester device object.

Areas or cases that should be tested

  • Create a new Harvester Cluster and assign vGpu device to it.
  • Go to Harvester and select the cluster provisioning VM from Virtual Machines tab.
  • Click on edit or view.
  • Go to vGpus devices tab and check if the vGpu is assigned to the VM

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I just have one comment about the change.

const clusterId = get(this.credential, 'decodedData.clusterId');
const url = `/k8s/clusters/${ clusterId }/v1`;

if (url) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we test for clusterId instead? I don't see any situation where url would be falsy given the statements above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, thanks!

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@torchiaf torchiaf requested a review from rak-phillip May 2, 2024 14:07
@torchiaf torchiaf merged commit 703836f into rancher:master May 2, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If you assign a vGPU profile via node driver to a VM it doesn't show up in Harvester UI
2 participants