Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cluster prov tests #10919

Merged
merged 1 commit into from
May 3, 2024
Merged

fix cluster prov tests #10919

merged 1 commit into from
May 3, 2024

Conversation

yonasberhe23
Copy link
Contributor

@yonasberhe23 yonasberhe23 commented Apr 30, 2024 •
edited
Loading

Summary

Fixes #

Occurred changes and/or fixed issues

Address failing tests in Jenkins run
Provision Node driver RKE1 cluster with AWS.can delete a Amazon EC2 RKE1 cluster
Provision Node driver RKE1 cluster with Azure."after all" hook: clean up for "can delete a Azure RKE1 cluster"

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@yonasberhe23 yonasberhe23 added this to the v2.9.0 milestone Apr 30, 2024
@yonasberhe23 yonasberhe23 requested a review from izaac April 30, 2024 17:39
@yonasberhe23 yonasberhe23 self-assigned this Apr 30, 2024
@yonasberhe23 yonasberhe23 force-pushed the fix_prov_tests branch 2 times, most recently from b2ec3d4 to 67fcff0 Compare April 30, 2024 19:02
@yonasberhe23 yonasberhe23 changed the title fix cluster prov test fix cluster prov tests Apr 30, 2024
izaac
izaac approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@yonasberhe23 yonasberhe23 merged commit c06436e into rancher:master May 3, 2024
26 checks passed
@yonasberhe23 yonasberhe23 deleted the fix_prov_tests branch May 3, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izaac izaac izaac approved these changes

Assignees

@yonasberhe23 yonasberhe23

Labels
None yet
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yonasberhe23 @izaac