Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.8] Select vGpus by id instead of vGpu type #10935

Merged
merged 1 commit into from
May 2, 2024

Conversation

torchiaf
Copy link
Contributor

@torchiaf torchiaf commented May 2, 2024

Summary

Fixes #10936

Occurred changes and/or fixed issues

Technical notes summary

This will fix a modeling issue. vGpu are select by type where we should use vGpu's id since there can be multiple vGpu profiles associated with the same vGpu type.

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@torchiaf torchiaf requested a review from rak-phillip May 2, 2024 18:31
@torchiaf torchiaf added this to the v2.8.next1 milestone May 2, 2024
@torchiaf torchiaf merged commit a8c6747 into rancher:release-2.8 May 2, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants