Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for job clone bug #10940

Merged
merged 1 commit into from
May 7, 2024
Merged

Add e2e test for job clone bug #10940

merged 1 commit into from
May 7, 2024

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented May 3, 2024

Summary

Fixes #10200

This PR adds test automation for the above issue.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@nwmac nwmac requested a review from aalves08 May 3, 2024 11:55
@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.9.0 milestone May 3, 2024
@nwmac nwmac changed the title e2e: Add tests for job clone bug Add e2e tests for job clone bug May 3, 2024
@nwmac nwmac changed the title Add e2e tests for job clone bug Add e2e test for job clone bug May 3, 2024
Copy link
Contributor

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 44dccd7 into rancher:master May 7, 2024
36 checks passed
@nwmac nwmac deleted the e2e-clone-job branch May 7, 2024 08:03

it('Should be able to clone a job', () => {
const jobName2 = `${ jobName }-2`;
const jobNameClone = `${ jobName }-3`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would these names possibly collision on a Cypress retry? Otherwise this overall looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save error when cloning a job
3 participants