Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INT] Refactored some of the plugins - 2 #10944

Merged
merged 6 commits into from
May 7, 2024

Conversation

eva-vashkevich
Copy link
Member

@eva-vashkevich eva-vashkevich commented May 3, 2024

Summary

Fixes #10774

Refactors:

  • trim-whitespace
  • positive-int-number
  • codemirror

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

The entire application is affected since these plugins are globally used.
In particular:

  • make sure labels and icons look correct (ie spacing)
  • make sure positive numbers are handled and displayed correctly
  • make sure yaml editor works as expected

Areas which could experience regressions

The entire application is affected since these plugins are globally used.

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

shell/initialize/plugins.js Outdated Show resolved Hide resolved
shell/plugins/codemirror.js Outdated Show resolved Hide resolved
shell/plugins/codemirror.js Outdated Show resolved Hide resolved
shell/plugins/positive-int-number.js Outdated Show resolved Hide resolved
shell/plugins/trim-whitespace.js Outdated Show resolved Hide resolved
@eva-vashkevich eva-vashkevich added the QA/manual-test Indicates issue requires manually testing label May 6, 2024
@eva-vashkevich eva-vashkevich changed the title [INT] Refactored some of the plugins -2 [INT] Refactored some of the plugins - 2 May 7, 2024
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eva-vashkevich eva-vashkevich merged commit ff7b136 into rancher:master May 7, 2024
35 checks passed
@eva-vashkevich eva-vashkevich deleted the iss10774-p02 branch May 7, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/extensions QA/manual-test Indicates issue requires manually testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Plugins and Directives to Provide a Path for Vue3
2 participants