Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e test for large extension that disables cache #11027

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

aalves08
Copy link
Contributor

@aalves08 aalves08 commented May 14, 2024

Summary

Fixes #10639

TO TEST/REVIEW THIS LOCALLY IT'S NEEDED:

Occurred changes and/or fixed issues

  • Add e2e test to check that extensions with cacheState: disabled work on Rancher Dashboard

Technical notes summary

Areas or cases that should be tested

  • Add git repo to Rancher for extension examples: local -> apps -> repositories
    type: git repo
    repo: https://github.com/rancher/ui-plugin-examples
    branch: main
  • Install extension Large-extension and make sure it works (top-level extension -> main nav)

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 self-assigned this May 14, 2024
@aalves08 aalves08 added this to the v2.9.0 milestone May 14, 2024
@aalves08 aalves08 force-pushed the 10639-add-e2e-test branch 2 times, most recently from 0f43525 to 3db5995 Compare May 24, 2024 09:35
@aalves08 aalves08 marked this pull request as ready for review June 3, 2024 13:13
@aalves08 aalves08 requested a review from jordojordo June 3, 2024 13:14
Copy link
Member

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalves08 aalves08 merged commit e750c25 into rancher:master Jun 18, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing an Extension Can Break if the Cache Is Disabled in the CRD
2 participants