Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily Remove codecov upload given caveats on codecov/codecov-action action #11107

Merged
merged 1 commit into from
May 24, 2024

Conversation

richard-cox
Copy link
Member

Summary

Contributes to #10663

Occurred changes and/or fixed issues

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@richard-cox richard-cox added this to the v2.9.0 milestone May 23, 2024
@richard-cox richard-cox requested a review from nwmac May 23, 2024 08:11
@nwmac nwmac changed the title Remove codecov upload given caveats on codecov/codecov-action action Temporarily Remove codecov upload given caveats on codecov/codecov-action action May 23, 2024
Copy link
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We can look at using the CLI to upload the reports

@richard-cox richard-cox merged commit f97b36b into rancher:master May 24, 2024
28 checks passed
@richard-cox richard-cox deleted the codecov branch May 24, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants