Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rancher provisioned/managed RKE2/K3s data-dir support #11158

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

aalves08
Copy link
Contributor

@aalves08 aalves08 commented Jun 3, 2024

Summary

Fixes #11061

Occurred changes and/or fixed issues

  • add k8sDistro dir to harvester cloud config path
  • add unit test

Technical notes summary

Areas or cases that should be tested

  • I just tested RKE2 cluster provisioning in general and it's working, afaik. Don't know how to test this further

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 added this to the v2.9.0 milestone Jun 3, 2024
@aalves08 aalves08 self-assigned this Jun 3, 2024
@aalves08
Copy link
Contributor Author

aalves08 commented Jun 3, 2024

FYI @torchiaf . This "touches" Harvester

@aalves08 aalves08 merged commit 254448d into rancher:master Jun 11, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rancher provisioned/managed RKE2/K3s data-dir support
2 participants