Making the call to i18n/init blocking to resolve a race condition #11214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyrancher
force-pushed
the
i18n-fix-dev
branch
2 times, most recently
from
6f8c650
to
c9f9079
Compare
codyrancher
force-pushed
the
i18n-fix-dev
branch
from
c9f9079
to
e5da676
Compare
codyrancher
changed the title
codyrancher
commented
Jun 12, 2024
Comment on lines
60
to
-61
| install: (Vue, _options) => { | ||
| _options?.store?.dispatch('i18n/init'); |
There was a problem hiding this comment.
Vue plugins can't have a blocking async install method otherwise I would've just made the modification here.
richard-cox
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11203
Technical notes summary
There was a race condition where certain pages would sometimes fail to render if the language was changed. This was caused by
i18n/initsometimes not completing before some of the page would begin to render and would ultimately lead toloadManagementnot getting called.Areas or cases that should be tested
/dashboard/c/_/fleet/fleet.cattle.io.gitrepoin a production build. You can update theui-dashboard-indexglobal setting tohttps://releases.rancher.com/dashboard/i18n-fix-dev/index.htmlto test.I was only able to reproduce the original issue in Chrome with a production build by refreshing the gitrepo page over and over.
Checklist