Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination Updates #11218

Merged
merged 6 commits into from
Jun 21, 2024
Merged

Pagination Updates #11218

merged 6 commits into from
Jun 21, 2024

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Jun 13, 2024

Summary

Contributes to #9545

Occurred changes and/or fixed issues

  • Update feature flag text given change to vai feature flag name
  • Ensure cluster explorer More Resources Role and Cluster Role tables use server-side pagination
    • default headers were provided, which meant the ui thought there were overrides and used them instead
    • as the default headers are the same as if they weren't hardcoded removing them is fine
  • Moved Global Settings --> Performance pagination setting to top of page
  • In some scenarios duplicate filter query params were being sent. Added a check deep down in pagination code to ensure dupes aren't sent
  • Fixed an issue which meant the age column did not appear as the last one

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@richard-cox richard-cox added this to the v2.9.0 milestone Jun 13, 2024
@richard-cox richard-cox changed the title Fix reference to updated FF name Pagination Updates Jun 13, 2024
- done at a rather base level to avoid having to compare objects
- can occurr if user pref to filter out system resources (c-, p- namespaces) which dupes some of system/user namespace filter
- caused by spurious hardcoded columns (which disable server-side pagination, unless overriden)
@richard-cox richard-cox marked this pull request as ready for review June 20, 2024 08:28
@richard-cox richard-cox merged commit c124439 into rancher:master Jun 21, 2024
30 checks passed
@richard-cox richard-cox deleted the pagination-updates branch June 21, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants