Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gitlab pipeline with node setup #11243

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

jordojordo
Copy link
Member

@jordojordo jordojordo commented Jun 14, 2024

Summary

Fixes #11240

Node.js v14 is incompatible with the latest dashboard build, bumping the package to nodejs16 does not solve the problem of the openssl incompatibility. In order to circumvent this, node.js v16 needs to be installed manually as the original package from https://download.opensuse.org/repositories/devel:languages:nodejs/SLE_12_SP5/devel:languages:nodejs.repo is outdated.

Occurred changes and/or fixed issues

I've added a node-setup script to the pipeline that will download the specified release declared in the NODE_DISTRO variable from the nodejs releases index.

Technical notes summary

The variables stanza now has some variables to alleviate any further issues with upgrading node and yq.

Areas or cases that should be tested

Installing the Extension catalog image that is published to the gitlab container registry of the repository.

Areas which could experience regressions

Screenshot/Video

You can see a passing test of this pipeline here.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@jordojordo jordojordo added this to the v2.9.0 milestone Jun 14, 2024
@jordojordo jordojordo requested a review from aalves08 June 14, 2024 14:45
@jordojordo jordojordo self-assigned this Jun 14, 2024
Copy link
Contributor

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jordojordo jordojordo merged commit 3b725e6 into rancher:master Jun 17, 2024
26 checks passed
@jordojordo jordojordo deleted the gitlab-ext-workflow branch June 17, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension Gitlab pipeline fails to build due to outdated nodejs and openssl packages
2 participants