Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean and simplify Nuxt utility #11258

Merged
merged 8 commits into from
Jun 18, 2024

Conversation

cnotv
Copy link
Contributor

@cnotv cnotv commented Jun 17, 2024

Summary

Fixes #11196

  • Removed a lot of unused code and unnecessary exports
  • Moved within files single use cases
  • Merged remaining functions with init helper
  • Added comments
  • Updated code to avoid reassignments or confusion, it should help with the migration

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@cnotv cnotv force-pushed the feature/11196-nuxt-util-cleanup branch from fc3df65 to d232fbf Compare June 17, 2024 21:26
@cnotv cnotv merged commit 1db3aad into rancher:master Jun 18, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean and simplify Nuxt utility
2 participants