Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKS: fix node group versioning and name input #11267

Merged

Conversation

mantis-toboggan-md
Copy link
Member

Summary

Fixes #11102
Fixes #11202
Fixes #11103

Occurred changes and/or fixed issues

This PR updates the EKS node group component to disable inputs when the cluster is new or when the current group is being added to a new cluster. It also adds version upgrading functionality in line with AKS - node groups' versioning.

Technical notes summary

Areas or cases that should be tested

Create a new cluster with a kubernetes version less than the latest available:

  1. Verify that the node group name is editable
  2. Verify that adding data to 'instance tags' is reflected in the node group's spec when saving
  3. Verify that there is a disabled input whose value aligns with the cluster kubernetes version
    Once that cluster has provisioned, go to edit it and verify that:
  4. The name of the existing node group is not editable
  5. When a new node group is added, its name is editable
  6. When a new node group is added, it has a disabled kubernetes version input whose value aligns with the cluster version
  7. if a new cluster kubernetes version is selected, the existing node group should have an info banner informing the user that they can upgrade when the cluster has been upgraded
    After upgrading the cluster, go back to edit and verify that:
  8. The old node group has a checkbox telling the user that they can upgrade the version
  9. The checkbox should go away if the cluster version is upgraded again

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@mantis-toboggan-md mantis-toboggan-md added this to the v2.9.0 milestone Jun 18, 2024
@mantis-toboggan-md mantis-toboggan-md changed the title Eks fix nodegroup EKS: fix node group versioning and name input Jun 20, 2024
Copy link
Member

@jordojordo jordojordo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change - otherwise looks good to me, everything worked as expected.

pkg/eks/components/NodeGroup.vue Outdated Show resolved Hide resolved
@mantis-toboggan-md mantis-toboggan-md merged commit 08bbb24 into rancher:master Jun 26, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants