refactor extension uninstall tests #11286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantis-toboggan-md
force-pushed
the
e2e-extensions
branch
from
492033d
to
b0e33ec
Compare
mantis-toboggan-md
force-pushed
the
e2e-extensions
branch
from
fdfc2b4
to
ac3f3a3
Compare
yonasberhe23
previously approved these changes
Jun 21, 2024
richard-cox
previously approved these changes
Jun 21, 2024
mantis-toboggan-md
dismissed stale reviews from richard-cox and yonasberhe23
via
4abdb21
yonasberhe23
previously approved these changes
Jun 21, 2024
yonasberhe23
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors extension uninstall tests so retries work. Currently, if one of the 3 extensions being uninstalled is successfully removed and another is not, when the test re-runs, it fails because its looking for an extension no longer present.
edit: updated the PR to disable the failing fleet test