Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read properties of undefined (reading 'component') while loading Elemental #11423

Merged

Conversation

aalves08
Copy link
Contributor

@aalves08 aalves08 commented Jul 11, 2024

Summary

Fixes #11414

Occurred changes and/or fixed issues

  • make sure we are adding the machine config to the subTypes array so that it is available while creating/editing an Elemental cluster

Technical notes summary

The problem lies with the edit view of provisioning.cattle.io.cluster where if the preferred provisioner (RKE1 or RKE2 - toggle on cluster creation screen, which is persistent) would omit the machine config for Elemental clusters if it was toggled for RKE1. This PR makes it available always in a scenario where a subType has been selected, which will cover the create/edit Elemental cluster direct links.

Areas or cases that should be tested

  1. Add the elemental-ui repo to local cluster -> apps -> repositories:
    type git
    url: https://github.com/rancher/elemental-ui
    branch: gh-pages
  2. Install Elemental version 1.3.1-rc7 (only published version compliant with Rancher 2.9)
  3. Start elemental locally (install extension and operator + crds)
  4. Go to cluster management -> hit create -> toggle the rke indicator to rke1
  5. Go to Create Elemental cluster (via Elemental extension -> dashboard -> button Create Elemental Cluster
  6. Make sure interface loads fine and that cluster creation succeeds
  7. Go to cluster management and edit the Elemental cluster
  8. Make sure interface loads fine and that cluster edit succeeds

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

…hat it is available while creating/editing an Elemental cluster
@aalves08 aalves08 added this to the v2.10.0 milestone Jul 11, 2024
@aalves08 aalves08 self-assigned this Jul 11, 2024
@rancher-ui-project-bot rancher-ui-project-bot bot modified the milestones: v2.10.0, v2.9.0 Jul 11, 2024
Copy link
Member

@mantis-toboggan-md mantis-toboggan-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eva-vashkevich
Copy link
Member

Tried creating and editing RKE1, RKE2 and Elemental

@mantis-toboggan-md mantis-toboggan-md merged commit 102f1e6 into rancher:master Jul 12, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading 'component') while loading Elemental
3 participants