Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Codecov report using CLI #11442

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Upload Codecov report using CLI #11442

wants to merge 3 commits into from

Conversation

torchiaf
Copy link
Contributor

@torchiaf torchiaf commented Jul 15, 2024

Summary

Fixes #11106

Occurred changes and/or fixed issues

Technical notes summary

  • It re-enables tests coverage upload using the Codecov CLI.
  • Using codecov/codecov-action is discouraged (issue available on request)

Areas or cases that should be tested

image

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@torchiaf torchiaf added this to the v2.10.0 milestone Jul 15, 2024
@torchiaf torchiaf requested review from nwmac and cnotv July 15, 2024 17:25
@torchiaf torchiaf mentioned this pull request Jul 15, 2024
7 tasks
@torchiaf torchiaf changed the title 11106 codecov Upload Codecov report using CLI Jul 15, 2024
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Copy link
Contributor

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the PR got the coverage updated https://app.codecov.io/github/rancher/dashboard/commit/d2f88aa8e3ef3719b7a280b689e4a2164e655b20
The link is in the CI logs.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable upload of coverage files to codecov
2 participants