Implement the directive of positive number #9451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WuJun2016 PTAL, thanks! |
|
I think the limit here is positive integers, so may be the name of the directive should be |
DaiYuzeng
force-pushed
the
positive-number
branch
from
572351d
to
bcaf164
Compare
mantis-toboggan-md
approved these changes
Sep 27, 2023
yonasberhe23
pushed a commit
to yonasberhe23/dashboard
that referenced
this pull request
Dec 20, 2023
yonasberhe23
pushed a commit
to yonasberhe23/dashboard
that referenced
this pull request
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Occurred changes and/or fixed issues
harvester/harvester#3977
Technical notes summary
Add
v-positive-numberdirective for the input which is the number type.@WuJun2016 Please take a look, thanks!
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video