Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster Provisioning: added RKE2 section #4075

Merged
merged 12 commits into from
May 13, 2022
Merged

Cluster Provisioning: added RKE2 section #4075

merged 12 commits into from
May 13, 2022

Conversation

nunix
Copy link
Contributor

@nunix nunix commented May 5, 2022

Split the Cluster Provisioning between RKE and RKE2 documentation.

To keep a "reading standardization", both sections have the same sub-topics.

Once the structure is agreed, RKE2 content needs to be updated.

For Rancher (product) docs only

When contributing to docs, please update the versioned docs. For example, the docs in the v2.6 folder of the rancher folder.

Doc versions older than the latest minor version should only be updated to fix inaccuracies or make minor updates as necessary. The majority of new content should be added to the folder for the latest minor version.

Fixes #3752

Split the Cluster Provisioning between RKE and RKE2 documentation.

To keep a "reading standardization", both sections have the same sub-topics.

Once the structure is agreed, RKE2 content needs to be updated.
Copy link
Contributor

@btat btat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Programmatically Creating RKE Clusters" section

Co-authored-by: Billy Tat <btat@suse.com>
Copy link
Contributor

@jtravee jtravee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits on the original docs :)

@nunix nunix requested review from btat and jtravee May 6, 2022 14:08
@btat btat requested review from snasovich and sowmyav27 May 6, 2022 19:04
Copy link

@markusewalker markusewalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nunix nunix requested a review from anupama2501 May 11, 2022 12:46
@nunix nunix requested a review from anupama2501 May 12, 2022 11:34
Copy link

@anupama2501 anupama2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@phillipsj phillipsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add that the vSphere node driver supports Windows? That is a key feature.

@btat btat dismissed phillipsj’s stale review May 13, 2022 20:21

Feedback added

@btat btat merged commit 55aaeef into rancher:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
9 participants