linter: fix go-header check #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with 2023 we started having false go-header positives. This was due to two things: 1) we need to add history during the checkout, as the go-header linter checks if the header in the sources should include the current year using 'git log' (if it fails, would check the file stats, but that has been just checked out, so will match current year for sure). 2) the current golangci-lint v1.50.1 is more sensible to the yaml syntax, in particular to the curly braces: the parser will work correctly if the curly braces have a space before (and after) the expression to be evaluated. Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
Itxaka
approved these changes
Jan 5, 2023
Codecov ReportBase: 49.63% // Head: 49.71% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
==========================================
+ Coverage 49.63% 49.71% +0.08%
==========================================
Files 31 31
Lines 3536 3536
==========================================
+ Hits 1755 1758 +3
+ Misses 1628 1626 -2
+ Partials 153 152 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
it drove me crazy to understand why it was failing... banged my head on this for almost 2 days 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with 2023 we started having false go-header positives. This was due to two things:
checks if the header in the sources should include the current year
using 'git log' (if it fails, would check the file stats, but that
has been just checked out, so will match current year for sure).
syntax, in particular to the curly braces: the parser will work
correctly if the curly braces have a space before (and after) the
expression to be evaluated.
Signed-off-by: Francesco Giudici francesco.giudici@suse.com