Do not store cpu info if not available #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Itxaka
force-pushed
the
fix_arm64_hardware_labels
branch
from
0c7bc29
to
d9f864c
Compare
Itxaka
changed the title
Codecov ReportBase: 49.71% // Head: 49.80% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
==========================================
+ Coverage 49.71% 49.80% +0.08%
==========================================
Files 31 31
Lines 3536 3542 +6
==========================================
+ Hits 1758 1764 +6
Misses 1626 1626
Partials 152 152
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
If run on aarch64 there is no info yet from ghw regarding the cpu threads/cores, so we end up with a useless label with zero values. This patch makes it so its not stored if the value is zero, as youo cant have 0 cores in a cpu Signed-off-by: Itxaka <igarcia@suse.com>
Itxaka
force-pushed
the
fix_arm64_hardware_labels
branch
from
d9f864c
to
454b3b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If run on aarch64 there is no info yet from ghw regarding the cpu threads/cores, so we end up with a useless label with zero values.
This patch makes it so its not stored if the value is zero, as youo cant have 0 cores in a cpu
Fixes #320
Signed-off-by: Itxaka igarcia@suse.com