Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move recovery hostname to cloud-config-defaults #1852

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Oct 30, 2023

Setting recovery hostname is mostly a nice-to-have and can be destructive so move it to cloud-config-defaults feature.

Setting recovery hostname is mostly a nice-to-have and can be
destructive so move it to cloud-config-defaults feature.

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
@frelon frelon requested a review from a team as a code owner October 30, 2023 12:40
@frelon frelon added kind/enhancement New feature or request area/feature kind/refactoring areas of code that needs refactoring and removed kind/enhancement New feature or request labels Oct 30, 2023
Copy link
Contributor

@anmazzotti anmazzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Signed-off-by: David Cassany Viladomat <dcassany@suse.com>
@davidcassany davidcassany enabled auto-merge (rebase) October 31, 2023 10:06
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidcassany davidcassany merged commit c4c19c1 into rancher:main Oct 31, 2023
13 of 14 checks passed
@frelon frelon deleted the recovery-hostname branch December 12, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature kind/refactoring areas of code that needs refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants