Refactor grub as a bootloader interface #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves grub logic into its own bootloader interface. In addition it adds helper methods to find EFI binaries, kernel and initrd based on patterns. No longer a distro detection is required. It also sets an elemental criteria for those bootloader files. In fact first place to look at is /usr/lib/elemental/bootloader, which gives a chance within the OS Dockerfile to prepare EFI binaries if default distro paths are not matching any of the default Elemental patterns. Kernel and initrd symlinks as /boot/vmlinuz and /boot/initrd are also created within the init command. This gives at build time more confidence that the kernel and initrd are set consistently with Elemental expectations. As part of the refactor BIOS firmware and MSDOS partition tables support is finally dropped. Signed-off-by: David Cassany <dcassany@suse.com>
frelon
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves grub logic into its own bootloader interface.
In addition it adds helper methods to find EFI binaries, kernel and initrd based on patterns. No longer a distro detection is required.
It also sets an elemental criteria for those bootloader files. In fact first place to look at is /usr/lib/elemental/bootloader, which gives a chance within the OS Dockerfile to prepare EFI binaries if default distro paths are not matching any of the default Elemental patterns.
Kernel and initrd symlinks as /boot/vmlinuz and /boot/initrd are also created within the init command. This gives at build time more confidence that the kernel and initrd are set consistently with Elemental expectations.
As part of the refactor BIOS firmware and MSDOS partition tables support is finally dropped.