Fix RISCV64 (VisionFive2) Tumbleweed example build #1871
Conversation
ldevulder
changed the title
ldevulder
changed the title
Yes, we have to wait until RISCV64 is added to Factory/Tumbleweed. |
ldevulder
force-pushed
the
fix-riscv64-example-build
branch
from
acc771b
to
119cb93
Compare
ldevulder
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1871 +/- ##
==========================================
- Coverage 75.96% 72.47% -3.50%
==========================================
Files 66 69 +3
Lines 6912 7274 +362
==========================================
+ Hits 5251 5272 +21
- Misses 1290 1624 +334
- Partials 371 378 +7 ☔ View full report in Codecov by Sentry. |
ldevulder
force-pushed
the
fix-riscv64-example-build
branch
from
119cb93
to
8797202
Compare
| @@ -19,17 +19,22 @@ DOCKER_SOCK?=/var/run/docker.sock | |||
| GIT_COMMIT?=$(shell git rev-parse HEAD) | |||
| GIT_COMMIT_SHORT?=$(shell git rev-parse --short HEAD) | |||
| GIT_TAG?=$(shell git describe --candidates=50 --abbrev=0 --tags 2>/dev/null || echo "v0.0.1" ) | |||
| VERSION?=${GIT_TAG}-g${GIT_COMMIT_SHORT} | |||
| VERSION?=$(GIT_TAG)-g$(GIT_COMMIT_SHORT) | |||
There was a problem hiding this comment.
What's the reason for changing {} to () ? In my eyes {} is used for variable references and () for running commands and assigning the output.
There was a problem hiding this comment.
In bash yes but in Makefile () can be used too (see here). As far as I remember in Makefile syntax it is used for variables declared inside the Makefile, which is the case for most of them (more all here). {} works too in GNU Makefile (not sure in non-GNU version, but we don't use it I know).
In our case we already had both, the idea here was mainly to be coherent and use the same for all vars, and use the initial Makefile syntax.
Fix the RISCV64 build example with openSUSE Tumbleweed. This commit also adds the `build-vf2-disk` to build raw disk image for VisionFive2 board, This commit also ensure that we are using consistent protection on Makefile variables. Signed-off-by: Loic Devulder <ldevulder@suse.com>
ldevulder
force-pushed
the
fix-riscv64-example-build
branch
from
8797202
to
415468c
Compare
This allow to build the Tumbleweed example for VisionFive2 RISCV64 board with
Makefile.This PR should adds:
Next step will be to try to enable mutli-arch build support to provide toolkit binary/image for x86-64, aarch64 and riscv64.