Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make network configuration part of the example, not defaults #1876

Conversation

davidcassany
Copy link
Contributor

No description provided.

@davidcassany davidcassany added the all-distros Runs CI for all available example images label Dec 12, 2023
@davidcassany davidcassany requested a review from a team as a code owner December 12, 2023 09:55
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany force-pushed the remove_network_setup_from_elemental_init branch from a95c457 to 4538593 Compare December 12, 2023 17:24
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

Attention: 350 lines in your changes are missing coverage. Please review.

Comparison is base (840c80c) 75.96% compared to head (49d52b0) 72.47%.
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/action/mount.go 5.94% 169 Missing and 5 partials ⚠️
cmd/config/config.go 3.50% 55 Missing ⚠️
pkg/config/config.go 15.78% 48 Missing ⚠️
pkg/types/v1/config.go 0.00% 28 Missing ⚠️
cmd/mount.go 23.07% 19 Missing and 1 partial ⚠️
pkg/features/features.go 18.75% 12 Missing and 1 partial ⚠️
pkg/constants/constants.go 0.00% 7 Missing ⚠️
pkg/systemd/unit.go 0.00% 3 Missing ⚠️
cmd/build-disk.go 0.00% 1 Missing ⚠️
cmd/init.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1876      +/-   ##
==========================================
- Coverage   75.96%   72.47%   -3.50%     
==========================================
  Files          66       69       +3     
  Lines        6912     7274     +362     
==========================================
+ Hits         5251     5272      +21     
- Misses       1290     1624     +334     
- Partials      371      378       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany merged commit 5763567 into rancher:main Dec 13, 2023
29 checks passed
@davidcassany davidcassany deleted the remove_network_setup_from_elemental_init branch December 13, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-distros Runs CI for all available example images
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants