Provide early boot systemd unit files within the associated dracut module #1886
Conversation
davidcassany
force-pushed
the
arrange_initramfs_units
branch
from
ce764d8
to
fe4bf4a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1886 +/- ##
=======================================
Coverage 73.60% 73.60%
=======================================
Files 69 69
Lines 7332 7332
=======================================
Hits 5397 5397
Misses 1544 1544
Partials 391 391 ☔ View full report in Codecov by Sentry. |
| @@ -1,4 +1,2 @@ | |||
| install_items+=" /usr/lib/systemd/system/elemental-setup-initramfs.service /etc/systemd/system/initrd.target.requires/elemental-setup-initramfs.service " | |||
| install_items+=" /usr/lib/systemd/system/elemental-setup-rootfs.service /etc/systemd/system/initrd-fs.target.requires/elemental-setup-rootfs.service " | |||
There was a problem hiding this comment.
I saw dracut error messages trying to execute those, that's how all this PR started.
pkg/features/embedded/elemental-rootfs/etc/dracut.conf.d/02-elemental-rootfs.conf
Show resolved
Hide resolved
pkg/features/features.go
Outdated
| @@ -146,11 +146,7 @@ func Get(names []string) ([]*Feature, error) { | |||
| return features, fmt.Errorf("Conflicting features: %s and %s", FeatureElementalRootfs, FeatureImmutableRootfs) | |||
| } | |||
|
|
|||
| units := []*systemd.Unit{ | |||
| systemd.NewUnit("elemental-rootfs.service"), | |||
There was a problem hiding this comment.
Was there an error for these units? These are actually pretty handy to include since you can run systemctl status elemental-rootfs in the booted system and see failures/logs..
There was a problem hiding this comment.
good point I am not sure if this will still be de case. I mean the unit is there but mostly managed by the initramfs systemd unit.
The thing is that I to make inst_simple command in module-setup.sh functional having the service file within the module makes it easy. Probably we could use the full path in there as long as the unit file and the dracut module are in the same feature it shouldn't be a problem having a hardcoded full path in there. I can give it a quick test.
davidcassany
force-pushed
the
arrange_initramfs_units
branch
from
fe4bf4a
to
91ee0c8
Compare
Signed-off-by: David Cassany <dcassany@suse.com>
davidcassany
force-pushed
the
arrange_initramfs_units
branch
from
91ee0c8
to
3b07f37
Compare
No description provided.